GDQuest / GDQuest/GDScript-formatter

Linter: no-else-return failing to detect return in this case

Open
#339 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
455
Forks
39
Avg merge
1d 15h
Merged PRs (30d)
4

Description

There is a bug in your linter that causes it to not recognize that the designated block can fail the if statement and skip the return statement:
1) The incorrect warning is:
“WARNING on line 75 (no-else-return)
Unnecessary 'else' after 'if'/'elif' blocks that end with 'return'”

2) The code that triggered this error is:
...
#Return false if vector_angle falls between start_arc and end_arc.
#This will ensure that weapons can only fire within their designated arcs.
if end_arc > start_arc:
if vector_angle > end_arc or vector_angle < start_arc:
return false
else:
if vector_angle > end_arc and vector_angle < start_arc:
return false

#Ensure target is within range
if vector_to_target.length() > ability_range:
return false
else:
return true

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the linter implementation for the no-else-return rule and reproduce the warning with the provided nested if/else snippet. Done means the rule no longer reports the final else as unnecessary when the preceding branch can continue, with regression coverage for this case.

Written by the indexing model from the issue text.

Assessment

Tech stack
godot, rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.