[Bug]: terminal exec windows tests intermittently fail on quoted PowerShell sleep scripts
- Lenguaje dominante
- Rust
- Estrellas
- 2.3k
- Forks
- 231
- Merge medio
- 2 h 49 min
- PR fusionados (30 d)
- 589
Descripción
## Summary
The windows test scripts passed the PowerShell command as one quoted argument (`-Command "Start-Sleep -Milliseconds 250"`); depending on the shell quoting layer this can be parsed as a literal string rather than a command, producing flaky timeouts. The scripts drop the quotes so the tokens reach PowerShell directly.
## Area
src/crates/services/terminal/src/exec.rs (windows test scripts only). Crate: terminal-core.
## Reproduction or evidence
At 32f2427697 the windows test commands still quote the -Command payload (exec.rs windows test blocks, 4 sites :1950/:1996/:2099/:2247); intermittent failures show the sleep never starting, tripping the timeout assertion. Test-only change; production code is untouched.
## Environment
Windows runners (powershell quoting layer differences); baseline 32f2427697. The cfg(windows) test face was exercised by real local runs on a Windows host (not a cfg-excluded false green); the ubuntu/macos faces are covered by the compile check (those branches are unchanged).
---
AI-assisted change. Testing: verified locally on Windows (`cargo check -p terminal-core` exit 0; `cargo test --lib exec` 37 passed, 0 failed, including the four affected tests delayed_poll / lifecycle / tty_poll / control_kill).
Guía de contribución
Línea de trabajo
Abre src/crates/services/terminal/src/exec.rs e inspecciona los bloques de pruebas de Windows alrededor de las líneas 1950, 1996, 2099 y 2247, centrándote en cómo se pasan los argumentos de PowerShell -Command. Ejecuta cargo check -p terminal-core y cargo test --lib exec en Windows; se considera terminado cuando las cuatro pruebas afectadas pasan sin fallos intermitentes de timeout y las ramas que no son de Windows permanecen sin cambios.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- powershell, rust
- Área
- cli, testing
- Tipo de issue
- Error
- Dificultad
- 2/5
- Tiempo estimado
- 1-3 horas
- Estado de actividad
- Activo
- Claridad
- Bien especificado
- Aptitud para principiantes
- 88/100