GCWing / GCWing/OpenBitFun

[Bug]: remaining cargo metadata validation steps omit --format-version=1

Offen Anfängerfreundlich
#2,616 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Rust
Sterne
2.3k
Forks
231
Ø Merge
2 Std. 46 Min.
Gemergte PRs (30 T.)
577

Beschreibung

# Remaining cargo metadata validation steps omit --format-version 1

## Symptom

The release and nightly pipelines still call `cargo metadata` without an
explicit format version in four places:
`.github/workflows/linux-binaries.yml` lines 129 and 146, and
`.github/workflows/nightly-artifacts.yml` lines 161 and 207. When cargo
changes its default metadata output format, these steps print the same
compatibility warning that PR #2577 already eliminated for the three
calls in `ci.yml`.

## Root cause

#2577 pinned `--format-version 1` on the `ci.yml` validation steps and
the strict assertions in `check-github-config.test.mjs` that pin them,
but the two shared build workflows (`linux-binaries.yml` and
`nightly-artifacts.yml`) predate that change and were left with the bare
invocation.

## Fix

Pass `--format-version 1` explicitly in all four remaining steps, and
sync the strict command assertions in `check-github-config.test.mjs`
(lines 705, 801, 802) that pin these steps, mirroring the #2577 approach.

## Verification

`pnpm run check:github-config` passes both stages locally (12 workflow
files parsed; contract tests 19 pass / 0 fail / 1 environment-dependent
skip covered by an equivalent assertion). Remote CI is the final judge.

Assisted-by: AI agent (Claude)

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start with the four cargo metadata steps in .github/workflows/linux-binaries.yml and .github/workflows/nightly-artifacts.yml, then inspect the related strict command assertions in check-github-config.test.mjs around lines 705, 801, and 802. Run pnpm run check:github-config; done means all four workflow invocations and their assertions explicitly use --format-version 1 and the checks pass.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
github-actions, javascript, rust
Bereich
build-system, ci-cd, testing-qa
Issue-Typ
Bug
Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Aktivitätsstatus
Aktiv
Klarheit
Klar beschrieben
Anfängerfreundlichkeit
88/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.