FormidableLabs / FormidableLabs/spectacle-cli
Investigate: Remove webpack `resolve.alias`?
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 29
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
We have all our package.json:dependencies hard-coded as resolve.alias for our core webpack configuration to ensure:
- Needed deps are in the
requireresolution path (since CLI may be outside of this path); and, - To make sure we only have one installed library for those offenders that have singleton state (
react,react-dom, etc.)
Task
- See if we can avoid doing this hard coding?
- Check unintended consequences for continuing...
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with package.json dependencies and the core webpack configuration. Investigate whether the hard-coded resolve.alias entries are still needed for CLI require resolution and singleton libraries such as react and react-dom. Done means documenting the consequences and determining whether the aliases can be removed safely.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, webpack
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100