FormidableLabs / FormidableLabs/spectacle-cli

Investigate: Remove webpack `resolve.alias`?

Open
#2 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
29
Forks
7
PR merge metrics
No merged PRs in 30d

Description

We have all our `package.json:dependencies` hard-coded as `resolve.alias` for our core webpack configuration to ensure:

1. Needed deps are in the `require` resolution path (since CLI may be outside of this path); and,
2. To make sure we only have _one_ installed library for those offenders that have singleton state (`react`, `react-dom`, etc.)

Task

- [ ] See if we can avoid doing this hard coding?
- [ ] Check unintended consequences for continuing...

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.