FormidableLabs / FormidableLabs/react-swipeable

Touch tap results in mouse events

Ouverte
#231 9 commentaires 3 réactions 1 personne assignée Réclamée par @hartzis Voir sur GitHub
bug 🐛 has example ✅ has solution ✅
Langage dominant
TypeScript
Étoiles
2.1k
Forks
149
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

**Describe the bug**
Tapping in the component tracked by the handlers causes multiple handlers to be called

1. The `onTap` handler is called with event of type `touchend`
1. The `onSwiping` handler is called with some delta values
1. The `onTap` handler is called twice, both with event of type `mouseup`

**Steps or Sandbox to reproduce**
Observe the following codesandbox application console log when touch-tapping in the blue area.

https://codesandbox.io/s/react-swipeable-tap-bug-yrbyu

**Expected behavior**
WHEN both `trackMouse` and `trackTouch` options are set to `true`
GIVEN a single touch tap in the component
THEN only `onTap` handler is called, with one event of type `touchend`

**Device/Browser**
Tested on
* Dell XPS with touch screen, running Fedora 34, in Firefox, Chrome and Brave
* Samsung Galaxy S10, running Android 11, in Chrome and Brave

Sliding/swiping works very well in all the mentioned environments, but a single touch tap also gives the same result in all of them.

**Additional context**
The _react-swipeable_ hook as such is very time saving and smooth! Thanks for the great work!

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.