FormidableLabs / FormidableLabs/react-native-app-auth

Detect network errors on refresh token

Abierto
#861 1 comentario 0 reacciones 1 asignado Reclamado por @faizplus Ver en GitHub
enhancement issue-accepted
Lenguaje dominante
Java
Estrellas
2.3k
Forks
473
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Hi,

It appears that there's no robust way to check if the refresh request failed due to network errors. This is quite unfortunate, as it means you get logged out if you have no internet, which doesn't provide a great user experience. The only workaround I've found is to explicitly check if the error message contains "Connection error" for iOS and "Network error" for Android, but this feels far from ideal. Perhaps it would be possible to add another error code named "network_error" or something similar? Here's some code for reference:

``` javascript
try {
await refreshToken();
setIsLoggedIn(true);
} catch (error) {
if (message.includes('Connection error') || message.includes('Network error')) {
console.log('Connection error');
} else {
console.log('Refresh token failed, logging out...');
setSessionExpired(true);
setIsLoggedIn(false);
}
}
```

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.