FormidableLabs / FormidableLabs/react-live

Prismjs plugins/line highlighting

Open
#87 9 comments 3 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
4.6k
Forks
260
PR merge metrics
No merged PRs in 30d

Description

Because react-live relies on the Node version of prismjs, it's unable to use many prism plugins which rely on the DOM. As discussed over on their repo, there aren't definite plans to fix this: https://github.com/PrismJS/prism/issues/1171

It makes definite sense to use the node package, especially for server rendering.

At the same time I feel react-live is sorely missing some features, particularly line highlighting - being able to highlight lines can really helpful when presenting an evolving piece of code.

Wondering if any thought has gone into remedying this.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing react-live's existing PrismJS integration and the linked PrismJS issue about DOM-dependent plugins. Clarify the desired line-highlighting behavior and its server-rendering constraints, then define acceptance criteria and tests for highlighted lines before implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.