FormidableLabs / FormidableLabs/react-live

Support inline compilation errors

Aperta
#41 0 commenti 1 reazione 0 assegnatari Vedi su GitHub
enhancement
Lingua principale
TypeScript
Stelle
4.6k
Fork
260
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

The `LiveError` component is useful for displaying compilation errors. But the `LiveEditor` component could be even more useful if it showed inline errors. For example:

### Current UI
screen shot 2017-10-05 at 6 03 58 pm

### Potential UI
screen shot 2017-10-05 at 6 03 46 pm

This support could probably be added in such a way that is not dependent on a specific compiler/toolchain. For example, `LiveEditor` could expose an additional prop `errors` that looked something like this:

```js
type errors = Array<{
message: string,
rowNumber: number,
columnNumber?: number
}>
```

This issue is just being opened for discussion and is a follow-up from facebook/react/issues/11094 and reactjs/reactjs.org/issues/10

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.