Path normalization should not check drive letter on non-Windows

Open Beginner friendly
#219 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
76/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp
Domain
operating-systems

Research direction

Start in TruePath/PathStrings.cs at lines 176-191 and inspect how path normalization checks drive letters. Reproduce the behavior for C:/ and /: on Unix, then make the check OS-specific or independently controllable; done means these paths no longer break on Unix while drive-letter handling remains correct where applicable.

Written by the indexing model from the issue text.

Description

bug good first issue help wanted

See this: https://github.com/ForNeVeR/TruePath/blob/f410e9a174e3634fe1033026ad64130e05b2c772/TruePath/PathStrings.cs#L176-L191

It seems this will break for paths like C:/ or /: on Unix.

Guard this per OS. Best of all, make the OS or bool checkDriveLetter a parameter, to keep the function behavior independent of OS.

Dominant language
C#
Stars
104
Forks
19
Avg merge
8h 38m
Merged PRs (30d)
6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ForNeVeR/TruePath

All issues in ForNeVeR/TruePath

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.