Flipboard / Flipboard/NSUserDefaultsSimulatorPerformanceBoost
dispatch_barrier_async can lead to inconsistent values when using mutable objects
- 主要语言
- Objective-C
- 星标
- 40
- 派生
- 1
- PR 合并指标
- 30 天内没有已合并 PR
描述
dispatch_barrier_async works great for this project, except for the following situation:
1. NSMutableDictionary *registeredDefaults = [[NSMutableDictionary alloc] init];
2. [[NSUserDefaults standardUserDefaults] registerDefaults:registeredDefaults];
3. [registeredDefaults setObject:@"FOO" forKey:@"BAR"];
4. NSObject *value = [[NSUserDefaults standardUserDefaults] objectForKey:@"BAR"];
- With sim performance ON, value may be equal to nil or equal to @"FOO" depending on if line 3 executed before the internal barrier_async block executed.
- With sim performance OFF, value is always equal to nil. Mutations after line 2 are not acknowledged.
The code above is incorrect anyways (you wouldn't expect it to work) -- but we still need to honor the behavior of NSUserDefaults. You could emulate this bug using -setObject:forKey: with a mutable object.
贡献指南
这个仓库没有索引到贡献指南
调研方向
首先在启用和禁用模拟器性能的情况下重现已报告的 registerDefaults 和 setObject:forKey: 场景,然后跟踪 dispatch_barrier_async 的处理。完成标准是:突变始终遵循 NSUserDefaults 的行为,而不是依赖屏障时序或性能模式。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- objective-c
- 领域
- devtools
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 38/100