Flagsmith / Flagsmith/flagsmith-engine

Incorrect `reason` used for environment default flags

Aperta
#341 1 commento 0 reazioni 1 assegnatario Rivendicata da @bakirFS Vedi su GitHub
Lingua principale
Python
Stelle
10
Fork
5
Merge medio
4g 8m
PR unite (30g)
3

Descrizione

Currently the engine emits `DEFAULT` whenever the evaluation result is the environment default flag.

This should be:

1. `STATIC` if there are no targeting rules configured for the feature
2. `DEFAULT` if there are targeting rules configured, but the evaluation doesn't match them

i.e. if there are segment overrides for a feature, but they don't match the identity we are evaluating for, then return `DEFAULT`. If there are no segment overrides, return `STATIC`.

See [Resolution Reason](https://openfeature.dev/specification/types/#resolution-reason).

Acceptance Criteria:
- [ ] Change implemented in this repository and tested
- [ ] New version of engine released
- [ ] New engine version integrated into Flagsmith/flagsmith, Flagsmith/edge-api, Flagsmith/flagsmith-python-client, Flagsmith/edge-proxy
- [ ] Update `reason` logic in Flagsmith/flagsmith-go-client

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.