Flagsmith / Flagsmith/flagsmith-engine

Incorrect `reason` used for environment default flags

Open
#341 1 comment 0 reactions 1 assignee Claimed by @bakirFS View on GitHub
Dominant language
Python
Stars
10
Forks
5
Avg merge
4d 8m
Merged PRs (30d)
3

Description

Currently the engine emits `DEFAULT` whenever the evaluation result is the environment default flag.

This should be:

1. `STATIC` if there are no targeting rules configured for the feature
2. `DEFAULT` if there are targeting rules configured, but the evaluation doesn't match them

i.e. if there are segment overrides for a feature, but they don't match the identity we are evaluating for, then return `DEFAULT`. If there are no segment overrides, return `STATIC`.

See [Resolution Reason](https://openfeature.dev/specification/types/#resolution-reason).

Acceptance Criteria:
- [ ] Change implemented in this repository and tested
- [ ] New version of engine released
- [ ] New engine version integrated into Flagsmith/flagsmith, Flagsmith/edge-api, Flagsmith/flagsmith-python-client, Flagsmith/edge-proxy
- [ ] Update `reason` logic in Flagsmith/flagsmith-go-client

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.