Flagsmith / Flagsmith/flagsmith-cli

Fix Go doc-comment association for maxPages and getList

Abierto
#49 0 comentarios 0 reacciones 1 asignado Reclamado por @khvn26 Ver en GitHub
Lenguaje dominante
Go
Estrellas
12
Forks
3
Merge medio
14 h 56 min
PR fusionados (30 d)
8

Descripción

## Summary

Move the `maxPages` constant and its documentation above the `getList` doc comment in `internal/api/client.go`.

## Rationale

The current declaration is positioned between the `getList` documentation and the function. As a result, Go documentation associates the trailing paragraph with `maxPages`, while `getList` no longer has a correctly attached doc comment.

## Affected area

- `internal/api/client.go`
- `maxPages`
- `(*Client).getList`

## Required change

Reorder the declarations so that:
1. `maxPages` is immediately preceded by its own `// maxPages ...` comment.
2. The `// getList ...` comment immediately precedes `func (c *Client) getList(...)`.

## Acceptance criteria

- `maxPages` and `getList` each have a correctly attached Go doc comment.
- The change is documentation/declaration ordering only; pagination behaviour remains unchanged.

## Backlinks

- Deferred from PR #43: https://github.com/Flagsmith/flagsmith-cli/pull/43
- Review comment: https://github.com/Flagsmith/flagsmith-cli/pull/43#discussion_r3666673361
- Requested by: @khvn26

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.