FireDynamics / FireDynamics/LectureFireSimulation
fdsreader Module, DEVC data and meta information
- Dominant language
- Jupyter Notebook
- Stars
- 33
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Description
In the section [fdsreader Module](https://github.com/FireDynamics/LectureFireSimulation/blob/8b1f6f71e2891dc4e33020b688bae29c7c807863/book/content/tools/03_analysis/02_fdsreader.ipynb), I get the following error message with fdsreader `1.2.1`
```python
---------------------------------------------------------------------------
AttributeError Traceback (most recent call last)
in
1 for i in devc:
----> 2 print(f"ID: {devc[i].id},\t quantity: {devc[i].quantity.quantity},\t position: {devc[i].position}")
AttributeError: 'Quantity' object has no attribute 'quantity'
```
for
```python
for i in devc:
print(f"ID: {devc[i].id},\t quantity: {devc[i].quantity.quantity},\t position: {devc[i].position}")
```
Shouldn't it be?
```python
for i in devc:
print(f"ID: {devc[i].id},\t quantity: {devc[i].quantity.name},\t position: {devc[i].position}")
```
Contributor guide
No contributing guide indexed for this repository
Research direction
Open book/content/tools/03_analysis/02_fdsreader.ipynb and inspect the fdsreader Module section. Run the shown DEVC loop with fdsreader 1.2.1 to reproduce the AttributeError, then verify the corrected metadata expression produces the intended quantity information without an error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- documentation
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100