FireDynamics / FireDynamics/LectureFireSimulation

fdsreader Module, DEVC data and meta information

Open
#50 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
33
Forks
9
PR merge metrics
No merged PRs in 30d

Description

In the section [fdsreader Module](https://github.com/FireDynamics/LectureFireSimulation/blob/8b1f6f71e2891dc4e33020b688bae29c7c807863/book/content/tools/03_analysis/02_fdsreader.ipynb), I get the following error message with fdsreader `1.2.1`

```python
---------------------------------------------------------------------------
AttributeError Traceback (most recent call last)
in
1 for i in devc:
----> 2 print(f"ID: {devc[i].id},\t quantity: {devc[i].quantity.quantity},\t position: {devc[i].position}")

AttributeError: 'Quantity' object has no attribute 'quantity'
```

for

```python
for i in devc:
print(f"ID: {devc[i].id},\t quantity: {devc[i].quantity.quantity},\t position: {devc[i].position}")
```

Shouldn't it be?
```python
for i in devc:
print(f"ID: {devc[i].id},\t quantity: {devc[i].quantity.name},\t position: {devc[i].position}")
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.