Ferrite-FEM / Ferrite-FEM/Ferrite.jl
Naming of functions to get nodes on facets
- Lingua principale
- Julia
- Stelle
- 453
- Fork
- 115
- Merge medio
- 1g 17h
- PR unite (30g)
- 11
Descrizione
Currently, it is not obvious that `Ferrite.facets(::AbstractCell)` only returns the node ids of the vertices of each facet, hence, it could be good to rename these functions to have something like
```
facet_vertex_node_ids(c::AbstractCell) = facets(c) # Can leave old `facets` just for backwards compatibility?
function facet_node_ids(c::AbstractCell)
ipg = geometric_interpolation(c)
return map(facetdof_indices(ipg)) do dof_ids
map(i -> get_node_ids(c)[i], dof_ids)
end
end
function facet_node_ids(c::AbstractCell, facetnr::Int) # Possible for optimization, but doesn't seem necessary
ipg = geometric_interpolation(c)
return map(i -> get_node_ids(c)[i], facetdof_indices(ipg)[facetnr])
end
```
Ref #1259
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.