FasterXML / FasterXML/jackson-dataformat-xml

JAXB `@XmlJavaTypeAdapter` not working in conjunction with `java.util.Optional`

Ouverte
#588 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Java
Étoiles
631
Forks
246
Merge moyen
7 j 9 h
PR mergées (30 j)
13

Description

`@XmlJavaTypeAdapter` doesn't seem to work in conjunction with JDK's `Optional` class. I have written a unit test in order to replicate this issue:

```java
package org.example;

import static org.example.OptionalWithTypeAdapterTest.TestEnum.A;
import static org.junit.jupiter.api.Assertions.assertEquals;

import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.dataformat.xml.XmlMapper;
import com.fasterxml.jackson.datatype.jdk8.Jdk8Module;
import com.fasterxml.jackson.module.jakarta.xmlbind.JakartaXmlBindAnnotationModule;
import jakarta.xml.bind.annotation.XmlElement;
import jakarta.xml.bind.annotation.adapters.XmlAdapter;
import jakarta.xml.bind.annotation.adapters.XmlJavaTypeAdapter;
import java.util.Optional;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;

public class OptionalWithTypeAdapterTest {

public enum TestEnum {
A
}

public static class TestEnumAdapter extends XmlAdapter {

@Override
public TestEnum unmarshal(String aString) {
return TestEnum.valueOf(aString.toUpperCase());
}

@Override
public String marshal(TestEnum testEnum) {
return testEnum.name().toLowerCase();
}
}

public record TestObject1(
@XmlElement @XmlJavaTypeAdapter(TestEnumAdapter.class) TestEnum testEnum) {
}

public record TestObject2(
@XmlElement Optional testEnum) {
}

public record TestObject3(
@XmlElement @XmlJavaTypeAdapter(TestEnumAdapter.class) Optional testEnum) {
}

private XmlMapper xmlMapper;

@BeforeEach
public void setUp() {
xmlMapper = new XmlMapper();
xmlMapper.registerModule(new JakartaXmlBindAnnotationModule());
xmlMapper.registerModule(new Jdk8Module());
}

@Test
public void writeValueAsStringWithTypeAdapter() throws JsonProcessingException {
TestObject1 testObject = new TestObject1(A);
String actual = xmlMapper.writeValueAsString(testObject);
String expected = "a";
assertEquals(expected, actual);
}

@Test
public void writeValueAsStringWithOptional() throws JsonProcessingException {
TestObject2 testObject = new TestObject2(Optional.of(A));
String actual = xmlMapper.writeValueAsString(testObject);
String expected = "A";
assertEquals(expected, actual);
}

/**
* This test fails
*/
@Disabled
@Test
public void writeValueAsStringWithTypeAdapterAndOptional() throws JsonProcessingException {
TestObject3 testObject = new TestObject3(Optional.of(A));
String actual = xmlMapper.writeValueAsString(testObject);
String expected = "a";
assertEquals(expected, actual);
}
}
```

This doesn't seem to have anything to do with the fact that I'm using records. I tried the same test with plain classes and the third test still fails. I'm using java 17 and jackson 2.15.0-rc1.

[test.zip](https://github.com/FasterXML/jackson-dataformat-xml/files/11076267/test.zip)

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.