FHIR / FHIR/Ucum-java

Additional Validation and Conversion Tests

Aperta
#61 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Java
Stelle
26
Fork
18
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

As part my efforts to develop [ucumate](https://fhnaumann.github.io/ucumate/), I have created more tests. The tests are available as a JSON file and include publicly available code lists (such as the fhir-common codes list) as well as extensive edge case testing. The latter causes some problems for Ucum-java. Due to the ambiguity in the UCUM specification, there are some validation differences. These are explained [here](https://fhnaumann.github.io/ucumate/ucumate_ucumjava_bridge/#functional-json-test-difference).

I have also developed [drop-in replacement layer](https://fhnaumann.github.io/ucumate/ucumate_ucumjava_bridge/) that implements the `UCUMService` interface defined here. The behavior to Ucum-java is really close, but some validation differences exist. For like 95% of the commonly used codes this is not a problem, just the edge cases behave slightly different.

I can also contribute the test suite back to this library but I am unsure what the best way is.

Should I convert the test cases to the existing XML test suite style?
And what about the validation differences?

[ucum-tests.json](https://github.com/user-attachments/files/20805888/ucum-tests.json)

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.