FAForever / FAForever/faftools

mod validation is overly strict

Open
#31 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1
Forks
8
PR merge metrics
No merged PRs in 30d

Description

When uploading a mod via the python-api with `url = ""` in the `mod_info.lua`, this exception is thrown:

```
File "/code/api/mods.py", line 85, in mods_upload
process_uploaded_mod(temp_mod_path)
File "/code/api/mods.py", line 206, in process_uploaded_mod
mod_info = parse_mod_info(temp_mod_path)
File "/usr/local/lib/python3.5/site-packages/faf/tools/fa/mods.py", line 52, in parse_mod_info
raise ValueError(errors)
ValueError: {'url': ['Not a valid URL.']}
```

That is probably too strict.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.