Esri / Esri/geometry-api-java

OperatorCut is returning two empty geometries if there are no valid cuts. A geometry cursor containing only a null pointer should be returned instead.

未关闭
#44 0 条评论 0 个 reaction 已指派 1 人 已被 @stolstov 认领 在 GitHub 查看
enhancement
主要语言
Java
星标
710
派生
269
平均合并
7 天 23 小时
30 天内合并 PR
1

描述

The cases in question are
1. the cuttee and the cutter don't intersect at all
2. the cuttee is a polygon and cutter doesn't pass all the way through it
3. the cuttee is a polyline, the cutter touches the cuttee but b_consider_touch is false.

Currently, a pointer to a geometry cursor is returned. There are two empty geometries in the cursor, one for the left cut and one for the right cut. It would be a more obvious signal to the user that there were no valid cuts if a null pointer was returned instead.

Here are some simple cases to reproduce the issues listed above.

cutter1: {"paths":[[[1.5,0.5],[2.5,0.5]]]}

cutter2: {"paths":[[[0.5,0.5],[1.5,0.5]]]}

cutter3: {"paths":[[[0.2,0.4],[0.6,0.8]]]}

polygon (cuttee): {"rings":[[[0,0],[0,1],[1,1],[1,0],[0,0]]]}

polyline (cuttee): {"paths":[[[0.0,0.6],[0.4,0.2],[0.5,0.5]]]}

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。