EpistasisLab / EpistasisLab/scikit-rebate

Refactor: Do not import NumPy functions directly

Open
#8 1 comment 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
Jupyter Notebook
Stars
420
Forks
72
Avg merge
3m
Merged PRs (30d)
3

Description

We currently import several NumPy functions directly, e.g., [here](https://landscape.io/github/EpistasisLab/scikit-rebate/17/modules/skrebate/multisurf.py#L26). Normally this isn't an issue, but `min`, `max`, `mean`, etc. override the standard definitions of these functions in Python.

We should refactor the code to `import numpy as np` then replace all of the NumPy function calls with `np.`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with skrebate/multisurf.py, especially the direct NumPy imports and calls referenced in the issue, then search the repository for other direct NumPy function imports. Replace those calls with np-qualified calls and run the project's existing tests to confirm behavior is unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
numpy, python
Domain
machine-learning
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.