EnergySystemsModellingLab / EnergySystemsModellingLab/MUSE_OS

Questionable results when using the adhoc solver

Open
#545 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
29
Forks
12
PR merge metrics
No merged PRs in 30d

Description

I've had reports from the MEng students that supply values do not match consumption values when using the adhoc solver (UK Transport model). Switching to the scipy solver fixes the problem.

I have no idea what the problem is, just making a note of this as a warning to anyone that's still using the adhoc solver.

Ideally I'd quite like to drop the adhoc solver, although we can't do this yet as the scipy solver is unsuitable for some models due to memory issues. I think my efforts are probably better spent improving the scipy solver so that the adhoc solver becomes redundant, rather than fixing bugs in the adhoc solver (unless this turns out to be really easy to fix)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the UK Transport model with both the adhoc and scipy solvers, comparing supply and consumption values. Locate the solver entry points and model configuration used by that case; done means identifying the cause and correcting the mismatch, or documenting a reproducible limitation if the adhoc solver should not be changed.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.