EnergySystemsModellingLab / EnergySystemsModellingLab/MUSE_OS
MCA convergence is using absolute tolerance rather than relative tolerance
- Dominant language
- Python
- Stars
- 29
- Forks
- 12
- PR merge metrics
- No merged PRs in 30d
Description
From the paper:
However, as you can see [here](https://github.com/EnergySystemsModellingLab/MUSE_OS/blob/51f97ad485d2948b50a15282f9c8073dfa6d4f5d/src/muse/mca.py#L663) the model is actually using at the __absolute__ difference in the deviation between supply and demand (i.e. we're missing the division by Dk in equation A.33).
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reading src/muse/mca.py around line 663 and compare the convergence calculation with equation A.33 in the referenced paper. Confirm how the deviation between supply and demand is computed, then verify that the convergence criterion matches the paper's relative-tolerance definition and check the relevant MCA behaviour.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100