EnergySystemsModellingLab / EnergySystemsModellingLab/MUSE_OS

MCA convergence is using absolute tolerance rather than relative tolerance

Open
#415 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
29
Forks
12
PR merge metrics
No merged PRs in 30d

Description

From the paper:

Screenshot 2024-07-17 140136

However, as you can see [here](https://github.com/EnergySystemsModellingLab/MUSE_OS/blob/51f97ad485d2948b50a15282f9c8073dfa6d4f5d/src/muse/mca.py#L663) the model is actually using at the __absolute__ difference in the deviation between supply and demand (i.e. we're missing the division by Dk in equation A.33).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.