ElementsProject / ElementsProject/rust-elements

inverted fields in `hex::Error::InvalidLength`

Aperta
#189 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Rust
Stelle
57
Fork
40
Merge medio
11h 58m
PR unite (30g)
1

Descrizione

I am testing https://github.com/ElementsProject/rust-elements/pull/188 in a downstream lib

https://github.com/ElementsProject/rust-elements/blob/613204f38eeb8f4fcc767042197fd763965f057a/src/hex.rs#L33

I think the `expected, got` comment is wrong and the values used in the Display implementation are inverted.

I say so by looking at the macro impl after in a downstream lib I have this test failing to parse "aaaa" as asset id with

```
left: "bad hex string length 64 (expected 4)"
right: "bad hex string length 4 (expected 64)"
```

(the test was working with add54c80ba1821a16b88af59de16009f28379853)

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.