ElementsProject / ElementsProject/rust-elements

inverted fields in `hex::Error::InvalidLength`

Open
#189 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
57
Forks
40
Avg merge
11h 58m
Merged PRs (30d)
1

Description

I am testing https://github.com/ElementsProject/rust-elements/pull/188 in a downstream lib

https://github.com/ElementsProject/rust-elements/blob/613204f38eeb8f4fcc767042197fd763965f057a/src/hex.rs#L33

I think the `expected, got` comment is wrong and the values used in the Display implementation are inverted.

I say so by looking at the macro impl after in a downstream lib I have this test failing to parse "aaaa" as asset id with

```
left: "bad hex string length 64 (expected 4)"
right: "bad hex string length 4 (expected 64)"
```

(the test was working with add54c80ba1821a16b88af59de16009f28379853)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.