Bad arguments (in C++ code) to BlindTransaction() can cause memory corruption

https://github.com/ElementsProject/elements/blob/4e023af58b697f63d0612abd712e1f8310719217/src/blind.cpp#L407-L416

If the issuance blinding key or token blinding key is specified for the input when calling BlindTransaction, but the transaction input itself have null value in `issuance.nInflationKeys`/`issuance.nAmount`, then `num_blind_attempts` will be incremented, while the size of `value_blindptrs` and `asset_blindptrs` will not be increased with another 32 bytes of random data.

(the same issue can happen with `continue` at https://github.com/ElementsProject/elements/blob/4e023af58b697f63d0612abd712e1f8310719217/src/blind.cpp#L434-L435)

If `num_blind_attempts` is larger than the size `*_blindptrs` arrays, `secp256k1_pedersen_blind_generator_blind_sum` that is called later can go over the size of the arrays, because there's no check that the sizes are equal to `num_blind_attempts + num_known_input_blinds`. This can cause crash. `secp256k1_pedersen_blind_generator_blind_sum` will also write to the last blinder, and this can cause memory corruption.

Of course this is only possible by the calling C++ code being incorrect, supplying wrong transaction data, etc. But this raises the question - are these `continue` statements actually needed ? Wouldn't it be better to replace them with returning failure ? It seems that in both cases, either the transaction structure is wrong, or the arguments ` issuance_blinding_privkey`/`token_blinding_privkey` are wrong.

Comienza en src/blind.cpp en las líneas 407-416 y 434-435, y luego sigue los llamadores de BlindTransaction y la construcción de value_blindptrs y asset_blindptrs. Verifica cómo se gestionan los argumentos de emisión o de la clave de blinding no válidos y añade cobertura para cantidades que no coincidan; se considerará terminado cuando las entradas malformadas no puedan hacer que blind_sum lea o escriba más allá de los arrays.

Escrito por el modelo de indexación a partir del texto del issue.