ElementsProject / ElementsProject/elements

BlindTransaction() and VerifyAmounts() need detailed error return codes

Aperta
#1,199 2 commenti 0 reazioni 1 assegnatario Assegnata a @jamesdorfman Vedi su GitHub
enhancement
Lingua principale
C++
Stelle
1.2k
Fork
416
Merge medio
1g 23h
PR unite (30g)
15

Descrizione

The functions `BlindTransaction()` and `VerifyAmounts()` each have several failure paths, but only use -1 and false to indicate to the caller that an operation failed. This makes it difficult to report helpful error messages to the user.

The error paths could return an enum indicating the reason for failure, and the callers could then surface error strings to the user.

`BlindTransaction()`: https://github.com/ElementsProject/elements/blob/master/src/blind.cpp#L286
`VerifyAmounts()`: https://github.com/ElementsProject/elements/blob/master/src/confidential_validation.cpp#L134

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.