Make ownership filter consistent between relink and rimport
- Lingua principale
- Python
- Stelle
- 0
- Fork
- 2
- Merge medio
- 3g 2h
- PR unite (30g)
- 2
Descrizione
As of #31, `rimport` walks directories to find files to publish with no regard for who owns the file. `relink.py`, on the other hand, still filters to just the owner. This is necessary, I think, because the `rimport` makes it so commands are run as the staging owner, and thus we would need special handling to check that ownership by _the calling user_ is checked.
It may be acceptable to go either way on this: Both check ownership or neither does. It feels weird to have this obvious failure case possibly lead to situations where someone publishes someone else's file but then can't relink it, so I lean towards both checking.
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Direzione di ricerca
Compare the ownership filtering in relink.py with the directory walk in rimport, focusing on how the staging owner and calling user are represented. Resolve whether both commands should check ownership or neither should, then verify that publishing and relinking handle another user's file consistently.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- python
- Ambito
- authorization, cli
- Tipo di issue
- Bug
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Stato di attività
- Attiva
- Chiarezza
- Da chiarire
- Idoneità per principianti
- 45/100