ESMCI / ESMCI/inputdataTools

Make ownership filter consistent between relink and rimport

Open
#32 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
0
Forks
2
Avg merge
3d 2h
Merged PRs (30d)
2

Description

As of #31, `rimport` walks directories to find files to publish with no regard for who owns the file. `relink.py`, on the other hand, still filters to just the owner. This is necessary, I think, because the `rimport` makes it so commands are run as the staging owner, and thus we would need special handling to check that ownership by _the calling user_ is checked.

It may be acceptable to go either way on this: Both check ownership or neither does. It feels weird to have this obvious failure case possibly lead to situations where someone publishes someone else's file but then can't relink it, so I lean towards both checking.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.