Dstack-TEE / Dstack-TEE/dstack
certbot: `renew --once` exits 0 when the renewed hook fails
- 主要语言
- Rust
- 星标
- 544
- 派生
- 96
- 平均合并
- 23 小时 40 分钟
- 30 天内合并 PR
- 126
描述
Follow-up to #924.
`certbot renew --once` is the cron/one-shot entry point. #924 made it invoke the `renewed_hook` (correct — a one-shot renewal that skips the reload hook leaves the serving process on the old cert), but hook failures are only logged:
```rust
// dstack/certbot/src/bot.rs
match std::process::Command::new("/bin/sh").arg("-c").arg(hook).status() {
Ok(status) if status.success() => {}
Ok(status) => error!("renewed hook failed with status: {status}"),
Err(error) => error!("failed to run renewed hook: {error:?}"),
}
Ok(true)
```
So `renew_and_run_hook` returns `Ok(true)` regardless, and `certbot renew --once` exits 0 even when the hook never ran or exited non-zero. A cron job or systemd `OneShot` unit wrapping this sees success while the certificate on disk is new and the serving process is still holding the old one — exactly the failure that is supposed to be visible.
Swallowing the error is right for the daemon (the next interval retries), wrong for `--once` (there is no next interval).
## Proposal
Split the two semantics. Options, roughly in order of preference:
1. Have `renew_and_run_hook` return the hook outcome (e.g. `Result` carrying `hook_failed`) and let the `--once` path in `cli/src/main.rs` turn a hook failure into a non-zero exit, while `run()` keeps logging and continuing.
2. Add a `fail_on_hook_error: bool` parameter, set from the `once` flag.
Either way the daemon loop must keep its current behaviour: a failing hook should not abort the loop.
贡献指南
调研方向
从 dstack/certbot/src/bot.rs 开始,跟踪 renew_and_run_hook 如何报告续期 hook 失败,然后继续跟踪 cli/src/main.rs 中的 --once 路径。保留 daemon 循环当前记录日志并继续的行为,但让 --once 在 hook 未运行或未成功退出时返回非零退出码。使用相关的 certbot 命令路径验证这两种语义。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- rust
- 领域
- cli
- Issue 类型
- 缺陷
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 64/100