Dstack-TEE / Dstack-TEE/dstack

gateway: ACME rotation does not deactivate the old account at the CA

未关闭
#1,009 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Rust
星标
544
派生
96
平均合并
23 小时 40 分钟
30 天内合并 PR
126

描述

Follow-up to #935.

`RotateAcmeCredentials` registers a replacement account and re-pins every ZT domain's CAA `accounturi` to it. The old ACME account remains valid at the CA.

## Impact

CAA pinning only prevents the old account from issuing for our domains as long as the attacker cannot alter DNS. If the rotation motive is key compromise and the attacker also controls (or races) DNS, the old account can still complete issuance — and CAA resolver caching leaves a window even after re-pinning. Rotation as shipped is an operational re-pin, not a compromise-response tool; #935 documents this but does not close the gap.

## Proposal

Deactivate the old account (RFC 8555 §7.3.6, `"status": "deactivated"`) after the new credentials are published and CAA re-pinning succeeds:

- best-effort with a warning on failure, since the old credential may already be unusable (that is one reason to rotate);
- requires loading the old credential before overwriting it in KV, so the deactivation step must be sequenced into `do_rotate_acme_credentials`;
- check what `instant-acme` exposes for account deactivation.

贡献指南

打开贡献指南

调研方向

Start with do_rotate_acme_credentials and the RotateAcmeCredentials flow, then check what instant-acme exposes for RFC 8555 account deactivation. Preserve the old credential before overwriting it in KV, publish the replacement credentials and CAA pinning first, and make old-account deactivation best-effort with a warning. Done means the old account is deactivated when possible without failing rotation when it is already unusable.

由索引模型根据 Issue 内容生成。

评估

技术栈
rust
领域
security
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
冷清
描述清晰度
基本清楚
新手友好度
55/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。