DiamondLightSource / DiamondLightSource/sci-react-ui

Tweak VisitInput to match "established" Glossary terms

Aperta
#93 6 commenti 0 reazioni 0 assegnatari Vedi su GitHub
accepted
Lingua principale
TypeScript
Stelle
8
Fork
3
Merge medio
3g 15h
PR unite (30g)
5

Descrizione

"Visit" has been deprecated (in Diamond's GraphQL) for - the more enigmatic - "Instrument Session Id". For reasons.

It should be (at the least) possible to change the label of the current Visit Input to something else, to allow the name change.

However... perhaps the name of the component should be switched over too. In this case it may be better to have two components based on the same underlining code, so as not to break current use of VisitInput - but this is a goodopportunity to refactor the component into more useful parts, usable in future input boxes.

Thoughts?

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.