DiamondLightSource / DiamondLightSource/sci-react-ui
Tweak VisitInput to match "established" Glossary terms
Open
accepted
- Dominant language
- TypeScript
- Stars
- 8
- Forks
- 3
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 5
Description
"Visit" has been deprecated (in Diamond's GraphQL) for - the more enigmatic - "Instrument Session Id". For reasons.
It should be (at the least) possible to change the label of the current Visit Input to something else, to allow the name change.
However... perhaps the name of the component should be switched over too. In this case it may be better to have two components based on the same underlining code, so as not to break current use of VisitInput - but this is a goodopportunity to refactor the component into more useful parts, usable in future input boxes.
Thoughts?
Contributor guide
Assessment
This issue has not been assessed yet.