DiamondLightSource / DiamondLightSource/sci-react-ui

NavLinks, FooterLinks, NavLink and FooterLink should be using `styled`.

Open
#89 0 comments 0 reactions 0 assignees View on GitHub
accepted priority: low
Dominant language
TypeScript
Stars
8
Forks
3
Avg merge
3d 15h
Merged PRs (30d)
5

Description

Currently NavLinks, FooterLinks, NavLink and FooterLink styles can all be removed by passing in `styles={}` , obviously, breaking the way they are displayed.

Other components are using the function `styled()`, e.g.
```
const BarStyled = styled(Bar)(
({ theme }) => ({
backgroundColor: theme.vars.palette.primary.light
})
);
```

Contributor guide

Open the contributing guide

Research direction

Locate the NavLinks, FooterLinks, NavLink and FooterLink components and compare their styling with other components that use styled(). Verify that passing styles={} can no longer remove the styles required for their display, then check the affected component behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.