DiamondLightSource / DiamondLightSource/sci-react-ui

Allow CustomLink type to create link menus

Open
#48 1 comment 0 reactions 0 assignees View on GitHub
accepted priority: low
Dominant language
TypeScript
Stars
8
Forks
3
Avg merge
3d 15h
Merged PRs (30d)
5

Description

Allow creation of the menu items, currently only in NavBar and Footer, to be created with an array of CustomLink types.

```react
export type CustomLink = {
name: string;
href: string;
}
```

e.g. Something like:
```react
const myLinks: CustomLink[] = [{
"name":"menu one",
"href":"/menu/one/"
}]

```

Contributor guide

Open the contributing guide

Research direction

Start by reading the NavBar and Footer components where menu items are currently created, then trace how their menu props are typed and rendered. Define the expected CustomLink[] input from the issue and verify that supplied names and hrefs appear as menu items in both components.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.