DiamondLightSource / DiamondLightSource/sci-react-ui
Change Proposal: Increment/Decrement Spinner Buttons for `NumberInput`
- Lenguaje dominante
- TypeScript
- Estrellas
- 8
- Forks
- 3
- Merge medio
- 3 d 15 h
- PR fusionados (30 d)
- 5
Descripción
## What is being proposed?
Add optional up/down spinner buttons to `NumberInput` so users can nudge a numeric value by a configurable step, instead of only being able to type a value directly.
## Why is this needed?
`NumberInput` currently only accepts typed input. For small, discrete adjustments (e.g. incrementing an integer count), typing is slower and more error-prone than a click-to-step control, which is a common affordance for numeric fields. There was previously no way to adjust the value without full keyboard entry.
## What will change?
- Behaviour: `NumberInput` can now render a vertical up/down `ButtonGroup` inside the field as an end adornment. Clicking increases/decreases the current value by step, clamped to `minValue`/`maxValue`. Buttons disable automatically at the limits.
- New props:
- `step?: number`: the increment/decrement amount, defaults to `1`.
- `spinnerButtons?: "always" | "onHover" | "never"`: controls spinner visibility. Defaults to `"onHover"` for all number modes except `"scientific"`, which defaults to `"never"` (since stepping isn't a natural operation on scientific-notation values).
- No new component: this extends the existing `NumberInput`.
## Interface changes (if any)
Additive/optional only — existing usages of NumberInput are unaffected.
```ts
```
## Breaking change?
- [ ] Yes
- [X] No
## Next steps
A maintainer will review this issue.
If accepted, it will be marked as `accepted` and a PR may then be opened.
Guía de contribución
Línea de trabajo
Comienza revisando el componente NumberInput existente y su comportamiento actual para numberMode, minValue y maxValue; después, inspecciona el pull request abierto #271 para entender el trabajo que ya está en curso. Se considera terminado cuando los botones de spinner opcionales admitan las configuraciones propuestas de paso y visibilidad, limiten los valores a los límites y no afecten a los usos existentes.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- typescript
- Área
- frontend
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 25/100