DiamondLightSource / DiamondLightSource/python-murfey

Murfey validates ALL MachineConfigs in the MachineConfig file

Abierto
#488 0 comentarios 0 reacciones 0 asignados Ver en GitHub
bug server
Lenguaje dominante
Python
Estrellas
2
Forks
1
Merge medio
1 d 10 h
PR fusionados (30 d)
19

Descripción

This means that multiple versions which have changed MachineConfig behaviour cannot coexist in the same file.

It might be worth modifying the function so that it only validates the MachineConfig relevant to the instrument of interest.

The current error:
- Updated the configs of one of our servers to reflect the new key format used in the latest Murfey release, but left the other ones untouched
- Noticed that Murfey server failed to start, so tried starting it manually while SSH'ed to one of our storage servers
- Got the following error message:
```text
$ murfey.server --feedback

[02/12/25 06:44:53] INFO Starting Murfey RabbitMQ thread __init__.py:310
INFO Starting Murfey server version 0.16.10 for __init__.py:314
beamline m14, listening on 0.0.0.0:8000
Traceback (most recent call last):
File "/dls_sw/apps/murfey/0.16.10/bin/murfey.server", line 8, in
sys.exit(run())
File "/dls_sw/apps/murfey/0.16.10/lib/python3.10/site-packages/murfey/server/__init__.py", line 330, in run
_running_server.run()
File "/dls_sw/apps/murfey/0.16.10/lib/python3.10/site-packages/uvicorn/server.py", line 66, in run
return asyncio.run(self.serve(sockets=sockets))
File "/dls_sw/apps/murfey/0.16.10/lib/python3.10/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "uvloop/loop.pyx", line 1518, in uvloop.loop.Loop.run_until_complete
File "/dls_sw/apps/murfey/0.16.10/lib/python3.10/site-packages/uvicorn/server.py", line 70, in serve
await self._serve(sockets)
File "/dls_sw/apps/murfey/0.16.10/lib/python3.10/site-packages/uvicorn/server.py", line 77, in _serve
config.load()
File "/dls_sw/apps/murfey/0.16.10/lib/python3.10/site-packages/uvicorn/config.py", line 435, in load
self.loaded_app = import_from_string(self.app)
File "/dls_sw/apps/murfey/0.16.10/lib/python3.10/site-packages/uvicorn/importer.py", line 19, in import_from_string
module = importlib.import_module(module_str)
File "/dls_sw/apps/murfey/0.16.10/lib/python3.10/importlib/__init__.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1050, in _gcd_import
File "", line 1027, in _find_and_load
File "", line 1006, in _find_and_load_unlocked
File "", line 688, in _load_unlocked
File "", line 883, in exec_module
File "", line 241, in _call_with_frames_removed
File "/dls_sw/apps/murfey/0.16.10/lib/python3.10/site-packages/murfey/server/main.py", line 14, in
import murfey.server.api.auth
File "/dls_sw/apps/murfey/0.16.10/lib/python3.10/site-packages/murfey/server/api/__init__.py", line 49, in
from murfey.server.api.auth import MurfeySessionID, validate_token
File "/dls_sw/apps/murfey/0.16.10/lib/python3.10/site-packages/murfey/server/api/auth.py", line 67, in
machine_config = get_machine_config()
File "/dls_sw/apps/murfey/0.16.10/lib/python3.10/site-packages/murfey/util/config.py", line 172, in get_machine_config
machine_config = from_file(
File "/dls_sw/apps/murfey/0.16.10/lib/python3.10/site-packages/murfey/util/config.py", line 77, in from_file
return {
File "/dls_sw/apps/murfey/0.16.10/lib/python3.10/site-packages/murfey/util/config.py", line 78, in
i: MachineConfig(**config[i])
File "pydantic/main.py", line 347, in pydantic.main.BaseModel.__init__
pydantic.error_wrappers.ValidationError: 1 validation error for MachineConfig
create_directories
value is not a valid list (type=type_error.list)
```

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Línea de trabajo

Start in murfey/util/config.py, following get_machine_config() into from_file(), then trace how the instrument of interest is selected during murfey.server --feedback startup. Check how mixed MachineConfig entries are loaded and validated. Done means an irrelevant config with the older key format no longer prevents the selected instrument's server from starting.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
python
Área
backend
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
48/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.