DiamondLightSource / DiamondLightSource/python-icebreaker

mistake in python-icebreaker/src/icebreaker/cli/ib_group.py

Ouverte
#13 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Python
Étoiles
11
Forks
6
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

There seems to be a mistake in ib_group.py.

In main(), the group_star variable is made from prepending the project_dir path to the in_mics input flag value.

`group_star = os.path.join(project_dir, args.in_mics)`

However, when this variable is used in the call to ib_igroups.main(), it is again prepended to the project_dir path:

`ib_igroups.main(
os.path.join(project_dir, parts_star), os.path.join(project_dir, group_star)
)`

This would result in the second argument to ib_igroups.main() being //

Code seems to work if I change from:

`group_star = os.path.join(project_dir, args.in_mics)`

to

`group_star = args.in_mics`

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.