DiamondLightSource / DiamondLightSource/python-icebreaker

mistake in python-icebreaker/src/icebreaker/cli/ib_group.py

Open
#13 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
11
Forks
6
PR merge metrics
No merged PRs in 30d

Description

There seems to be a mistake in ib_group.py.

In main(), the group_star variable is made from prepending the project_dir path to the in_mics input flag value.

`group_star = os.path.join(project_dir, args.in_mics)`

However, when this variable is used in the call to ib_igroups.main(), it is again prepended to the project_dir path:

`ib_igroups.main(
os.path.join(project_dir, parts_star), os.path.join(project_dir, group_star)
)`

This would result in the second argument to ib_igroups.main() being //

Code seems to work if I change from:

`group_star = os.path.join(project_dir, args.in_mics)`

to

`group_star = args.in_mics`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.