Devlight / Devlight/ArcProgressStackView

Possible bug with app:apsv_model_offset="10dp"

Open
#18 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
1.3k
Forks
203
PR merge metrics
No merged PRs in 30d

Description

When set app:apsv_model_offset="10dp" the circles get cut by the edges of the view, the solution is in the line 827 of the ArcProgressStackView.java

Change
final float modelOffset = (mProgressModelSize * i) +
(paintOffset + shadowOffset) - (mProgressModelOffset * i);

With
final float modelOffset = (mProgressModelSize * i) +
(paintOffset + shadowOffset) + (mProgressModelOffset * i);

if you put + (mProgressModelOffset * i); works perfectly

Hope this help
Best Regards

Contributor guide

No contributing guide indexed for this repository

Research direction

Open ArcProgressStackView.java and inspect line 827, where modelOffset is calculated. Reproduce the app:apsv_model_offset="10dp" case if possible, then verify that the circles are no longer cut by the view edges and that the offset calculation matches the reported correction.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile-dev
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.