DLR-RM / DLR-RM/BlenderProc

[BUG]: Haven texture leather_red_02 fails to load

Open
#456 3 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
3.7k
Forks
518
PR merge metrics
No merged PRs in 30d

Description

The following line does not create a new material and does not load the texture:
```python
bproc.api.loader.load_haven_mat(haven_textures_folder, ["leather_red_02"])
```
The reason is that the no color base texture was downloaded:
![image](https://user-images.githubusercontent.com/23340946/152511598-2494f965-e541-4814-b78b-32ab43f1d4af.png)

When manually downloading the texture from Haven, the issue becomes apparent:
![image](https://user-images.githubusercontent.com/23340946/152511898-aa1161b7-6fd0-4229-ab19-004fdf1d92b2.png)

This texture has two color variations, with names `Coll1` and `Coll2`, which are not downloaded by the [download_texture()](https://github.com/DLR-RM/BlenderProc/blob/e04e03f34b66702bbca45d1ac701599b6d764609/blenderproc/scripts/download_haven.py#L58)

Possible solution:
- add `Coll1` and `Coll2` to keys to be downloaded
- check for `_coll1_` in [load_haven_mat() ](https://github.com/DLR-RM/BlenderProc/blob/e04e03f34b66702bbca45d1ac701599b6d764609/blenderproc/python/loader/HavenMaterialLoader.py#L44)as well

Contributor guide

Open the contributing guide

Research direction

Start in blenderproc/scripts/download_haven.py at download_texture() and then inspect blenderproc/python/loader/HavenMaterialLoader.py at load_haven_mat(). Reproduce the leather_red_02 load, trace which texture keys are downloaded and recognized, and verify that the material and both color variation textures load successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
blender, python
Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.