ComputerScienceHouse / ComputerScienceHouse/conditional
Minify HTML to Reduce Load time and Data
- Lingua principale
- Python
- Stelle
- 12
- Fork
- 39
- Merge medio
- 1g 13h
- PR unite (30g)
- 1
Descrizione
# Why?
Currently the HTML returned from conditional is large and riddled with blank newlines. In fact if you go to `/spring_evals` the page request is 403 kb! This affects load time, and can affect users data usage when visiting the page on mobile data. Conditional is slow, mostly because of the LDAP calls, but we can make an effort to reduce load times on the client when possible.
# The Fix
We can use a library called [flask-optimize](https://github.com/sunary/flask-optimize) to deal with this at each request. When attaching it to that same `spring_evals` route, it was reduced from 403 kb to 9.5kb and load time was reduced by a full 6 seconds!
# Downsides
We add a new dependency, and may have to deal with adding a few ` `s. Honestly minimal imo
# Okay, so just fix it
I will. As soon as #169 is merged. It's a separate change and I don't want to group them together. There's also a chance for a conflict if I submit a second PR. I'll just wait for the sake of avoiding such conflicts
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Valutazione
Questa issue non è ancora stata valutata.