CommunityToolkit / CommunityToolkit/Windows
[SettingsCard] Change ActionIcon to utilize IconSource and IconSourceElement
Aperta
components::controls::settingscontrols
- Lingua principale
- C#
- Stelle
- 1.1k
- Fork
- 166
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
Currently, the `ActionIcon` is an instance of an `IconElement`. This is problematic, because the `IconElement` is a `FrameworkElement`, meaning it cannot be a shared resource, and therefore changing the icon requires a unique value for every instance. This means it cannot be set using styles.
The solution is to replace the `IconElement` with an `IconSource`, however this is a breaking change. As a result, a deprecation plan needs to be made
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.