CommunityToolkit / CommunityToolkit/Windows

[SettingsCard] Change ActionIcon to utilize IconSource and IconSourceElement

Open
#858 4 comments 0 reactions 1 assignee Claimed by @Avid29 View on GitHub
components::controls::settingscontrols
Dominant language
C#
Stars
1.1k
Forks
166
PR merge metrics
No merged PRs in 30d

Description

Currently, the `ActionIcon` is an instance of an `IconElement`. This is problematic, because the `IconElement` is a `FrameworkElement`, meaning it cannot be a shared resource, and therefore changing the icon requires a unique value for every instance. This means it cannot be set using styles.

The solution is to replace the `IconElement` with an `IconSource`, however this is a breaking change. As a result, a deprecation plan needs to be made

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.