CommunityToolkit / CommunityToolkit/Windows

Validate BehaviorBase<T> and what is needed (if anything) beyond Behavior<T>

Aperta
#27 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
components::behaviors need more info :pushpin: question
Lingua principale
C#
Stelle
1.1k
Fork
166
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

We probably want to file an issue about re-checking all this, as I know some of the original issues I believe were fixed in the underlying behaviors package, but I think we still do some extra logic here.

Probably a thing where when we can better test these and shore that up, we could try removing the intermediate class and see what happens or if anything breaks. (Assuming we have enough coverage)

_Originally posted by @michael-hawker in https://github.com/CommunityToolkit/Windows/pull/20#discussion_r1167170975_

Related Toolkit Discussion: https://github.com/CommunityToolkit/WindowsCommunityToolkit/issues/3856

with specifically more prior context and links here: https://github.com/CommunityToolkit/WindowsCommunityToolkit/issues/3856#issuecomment-801471909

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start with the related Toolkit Discussion and the linked prior context, then compare BehaviorBase with Behavior and identify which extra logic remains here. Establish sufficient test coverage before evaluating whether the intermediate class can be removed without breaking behavior.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
csharp
Ambito
developer-experience
Tipo di issue
Refactoring
Difficoltà
5/5
Tempo stimato
Più di una settimana
Stato di attività
Ferma
Chiarezza
Da chiarire
Idoneità per principianti
20/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.