CommunityToolkit / CommunityToolkit/Windows

AdvancedCollectionView is not NULL annotated correctly

未关闭
#246 4 条评论 0 个 reaction 已指派 2 人 已被 @Arlodotexe 认领 在 GitHub 查看
bug components::collections
主要语言
C#
星标
1.1k
派生
166
PR 合并指标
30 天内没有已合并 PR

描述

### Describe the bug

While this

```cs
AdvancedCollectionView acv = new AdvancedCollectionView();
acv.Add(null);
```

is working as the underlying source is an IList which supports this behaviour, all the methods in `AdvanceCollectionView` are missing the null annotations. Nevertheless this code, after updating to v8 now displays a warning: `CS8625 Cannot convert null literal to non-nullable reference type.`

### Steps to reproduce

```text
object? item = null;
AdvancedCollectionView acv = new AdvancedCollectionView();
acv.Add(item); // <- warning here
acv.Contains(item); // <- warning here
```

### Expected behavior

Expected behaviour is as it was before v8, no warnings.

### Screenshots

_No response_

### Code Platform

- [ ] UWP
- [X] WinAppSDK / WinUI 3
- [ ] Web Assembly (WASM)
- [ ] Android
- [ ] iOS
- [ ] MacOS
- [ ] Linux / GTK

### Windows Build Number

- [ ] Windows 10 1809 (Build 17763)
- [ ] Windows 10 1903 (Build 18362)
- [ ] Windows 10 1909 (Build 18363)
- [ ] Windows 10 2004 (Build 19041)
- [ ] Windows 10 20H2 (Build 19042)
- [ ] Windows 10 21H1 (Build 19043)
- [ ] Windows 10 21H2 (Build 19044)
- [X] Windows 10 22H2 (Build 19045)
- [ ] Windows 11 21H2 (Build 22000)
- [ ] Other (specify)

### Other Windows Build number

_No response_

### App minimum and target SDK version

- [ ] Windows 10, version 1809 (Build 17763)
- [ ] Windows 10, version 1903 (Build 18362)
- [ ] Windows 10, version 1909 (Build 18363)
- [ ] Windows 10, version 2004 (Build 19041)
- [X] Windows 10, version 2104 (Build 20348)
- [ ] Windows 11, version 22H2 (Build 22000)
- [ ] Other (specify)

### Other SDK version

_No response_

### Visual Studio Version

2022

### Visual Studio Build Number

_No response_

### Device form factor

Desktop

### Additional context

_No response_

### Help us help you

Yes, I'd like to be assigned to work on this item.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。