CommunityToolkit / CommunityToolkit/Windows

Remove ThemeListener? And/or refactor?

Offen
#135 2 Kommentare 1 Reaktion 1 zugewiesene Person Beansprucht von @niels9001 Auf GitHub ansehen
components::helpers enhancement good first issue
Vorherrschende Sprache
C#
Sterne
1.1k
Forks
166
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

`ThemeListener` doesn't work in the Windows App SDK at the moment, so thinking we should remove it for now until it's supported in the WASDK?

In either case, we should refactor to remove the call to `EnqueueAsync` for the `DispatcherQueue` Extensions so we don't need the Helper package to depend on the Extensions package. I think that's the only call there:

https://github.com/CommunityToolkit/Windows/blob/be4577e5885a0a1e2b7f870e9551dcf8f057f1e5/components/Helpers/src/ThemeListener.cs#L110-L123

Seems to be the only use of the Extensions I believe in this project. (which also means the Collections package is pulling them in as they depend on the Helpers)

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.