CommunityToolkit / CommunityToolkit/Windows

Remove ThemeListener? And/or refactor?

Open
#135 2 comments 1 reaction 1 assignee Claimed by @niels9001 View on GitHub
components::helpers enhancement good first issue
Dominant language
C#
Stars
1.1k
Forks
166
PR merge metrics
No merged PRs in 30d

Description

`ThemeListener` doesn't work in the Windows App SDK at the moment, so thinking we should remove it for now until it's supported in the WASDK?

In either case, we should refactor to remove the call to `EnqueueAsync` for the `DispatcherQueue` Extensions so we don't need the Helper package to depend on the Extensions package. I think that's the only call there:

https://github.com/CommunityToolkit/Windows/blob/be4577e5885a0a1e2b7f870e9551dcf8f057f1e5/components/Helpers/src/ThemeListener.cs#L110-L123

Seems to be the only use of the Extensions I believe in this project. (which also means the Collections package is pulling them in as they depend on the Helpers)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.